bug: tx carrying multiple bundles doesn't split cost correctly #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfault-magnet
requested review from
digorithm,
hal3e,
MujkicA and
Salka1988
as code owners
MujkicA
approved these changes
Jan 10, 2025
digorithm
approved these changes
Jan 10, 2025
Salka1988
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #183
codeveloped with: @hal3e
If a tx carries blobs that make up different bundles, the total cost is given to the first bundle even though it only contributed a part of the total data.
This PR proportionally splits up the cost to all bundles that have their blobs in the tx.